Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Waveshare 4.2in B/W e-paper driver #183

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Add Waveshare 4.2in B/W e-paper driver #183

merged 3 commits into from
Aug 25, 2020

Conversation

timboldt
Copy link
Contributor

Like the other EPD drivers in this repo, this driver is a direct port of the Waveshare reference implementation for Arduino, located at https://github.com/waveshare/e-Paper.

@conejoninja
Copy link
Member

It looks fine and I assume this is working properly too.
Thanks for your contribution, great addition.

@conejoninja
Copy link
Member

One thing missing before merging this PR, is to add the driver to the README.md list and to the smoke-tests (Makefile)

@timboldt
Copy link
Contributor Author

It looks like I should do something like this? i.e. Add it to the README list, add an example, and add the example to the makefile.

fd9b1ba

@conejoninja
Copy link
Member

yes exactly that, have in mind that the number of devices (in README.md file) should be 53. Your base branch has "51", but a new driver was accepted, bumping the number to 52, this driver will be the 53th

@deadprogram
Copy link
Member

hI @timboldt can you please also add a smoke test for the new driver like this: https://github.com/tinygo-org/drivers/blob/dev/Makefile#L156-L157

Thank you.

@timboldt
Copy link
Contributor Author

Will do.

@deadprogram
Copy link
Member

Thank you very much for working on this! @timboldt now squash/merging.

@deadprogram deadprogram merged commit b1ae52d into tinygo-org:dev Aug 25, 2020
@sago35
Copy link
Member

sago35 commented Aug 27, 2020

link : #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants