Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ili9341: Cache address window to prevent sending unnecessary commands #171

Merged
merged 2 commits into from
Aug 3, 2020
Merged

ili9341: Cache address window to prevent sending unnecessary commands #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4fe646
cache address window to prevent sending unnecessary commands
ardnew Jul 13, 2020
195219b
Merge branch 'opt-ili9341-cache' into dev
ardnew Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions ili9341/ili9341.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ type Device struct {
rotation Rotation
driver driver

x0, x1 int16 // cached address window; prevents useless/expensive
y0, y1 int16 // syscalls to PASET, CASET, and RAMWR

dc machine.Pin
cs machine.Pin
rst machine.Pin
Expand All @@ -37,6 +40,10 @@ func (d *Device) Configure(config Config) {
d.height = config.Height
d.rotation = config.Rotation

// try to pick an initial cache miss for one of the points
d.x0, d.x1 = -(d.width + 1), d.x0
d.y0, d.y1 = -(d.height + 1), d.y0

output := machine.PinConfig{machine.PinOutput}

// configure chip select if there is one
Expand Down Expand Up @@ -253,13 +260,26 @@ func (d *Device) StopScroll() {
func (d *Device) setWindow(x, y, w, h int16) {
//x += d.columnOffset
//y += d.rowOffset
d.sendCommand(CASET, []uint8{
uint8(x >> 8), uint8(x), uint8((x + w - 1) >> 8), uint8(x + w - 1),
})
d.sendCommand(PASET, []uint8{
uint8(y >> 8), uint8(y), uint8((y + h - 1) >> 8), uint8(y + h - 1),
})
d.sendCommand(RAMWR, nil)
wr := false
x1 := x + w - 1
if x != d.x0 || x1 != d.x1 {
wr = true
d.sendCommand(CASET, []uint8{
uint8(x >> 8), uint8(x), uint8(x1 >> 8), uint8(x1),
})
d.x0, d.x1 = x, x1
}
y1 := y + h - 1
if y != d.y0 || y1 != d.y1 {
wr = true
d.sendCommand(PASET, []uint8{
uint8(y >> 8), uint8(y), uint8(y1 >> 8), uint8(y1),
})
d.y0, d.y1 = y, y1
}
if wr {
d.sendCommand(RAMWR, nil)
}
}

//go:inline
Expand Down