Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(base16-github) Readability fix needed #35

Open
chawyehsu opened this issue Nov 13, 2024 · 1 comment
Open

(base16-github) Readability fix needed #35

chawyehsu opened this issue Nov 13, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@chawyehsu
Copy link

chawyehsu commented Nov 13, 2024

Yesterday I spent some time getting my base16-snazzy-scheme and base16-concfg revamped, and noticed there's an unresolved issue of color mapping I opened years ago about the base16-github scheme. I just post it here for xref and see if anyone is interested in getting it fixed. I don't currently use this scheme though.

chawyehsu/base16-concfg#3

@chawyehsu chawyehsu added the bug Something isn't working label Nov 13, 2024
@JamyGolden
Copy link
Member

Thanks for creating an issue about this. I should create an issue to go through all the schemes and if there isn’t a good reason to avoid the suggestions in the styling guidelines, then change the theme, in line with the themes colours, to fit the styling guidelines. I’ll have a look at creating a PR to fix this later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants