Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base16-github has bad readability #3

Open
chawyehsu opened this issue Aug 28, 2018 · 0 comments
Open

base16-github has bad readability #3

chawyehsu opened this issue Aug 28, 2018 · 0 comments

Comments

@chawyehsu
Copy link
Owner

chawyehsu commented Aug 28, 2018

Chars are invisible when using the base16-github scheme.

For comparison:

base16-github base16-snazzy
capture22222 capture333333

Preview of the base16-github scheme, notice that it does not have proper 8 shades of grey:

preview Github

So the original base16-github-scheme is problematic, I'm considering to fork it and remake the color scheme definition. Would be better to contribute to https://github.com/tinted-theming/schemes/blob/spec-0.11/base16/github.yaml for an update to the scheme, that should follow the official github syntax color scheme:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@chawyehsu and others