Redefine specification for bright colors #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musjj
requested review from
JamyGolden and
FredHappyface
and removed request for
a team
Co-authored-by: Jamy <[email protected]>
JamyGolden
approved these changes
Nov 19, 2024
|
Yeah, I think I'm fine with this being merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the definition of bright colors more specific, as per the discussion in #31. This also reverts the color order back to the previous version, so that
base08-base0Eare the primary colors, whilebase12-base17are the secondary colors.A grayscaled version of the example is also included to visualize the contrast between bright vs non-bright colors in terms of luminosity.