Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): correct detect iso code for Kazakhstan when phone number start with +7 #4217

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #4193

@lumberjack-bot
Copy link

lumberjack-bot bot commented Apr 14, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Apr 14, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
320.6KB (+86B +0.03%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
190.89KB +10%
demo/browser/runtime.(hash).js
36.99KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%

Total files change +91B +0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.16MB (+118B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

Visit the preview URL for this PR (updated for commit 0010bb8):

https://taiga-ui--pr4217-splincode-fix-issues-fquwo1u9.web.app

(expires Sat, 15 Apr 2023 06:50:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@splincode splincode force-pushed the splincode/fix/issues/4193 branch 2 times, most recently from 09814db to 12ff482 Compare April 14, 2023 06:45
@splincode splincode force-pushed the splincode/fix/issues/4193 branch from 12ff482 to 0010bb8 Compare April 14, 2023 06:46
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (92016fb) 61.32% compared to head (0010bb8) 61.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4217      +/-   ##
==========================================
+ Coverage   61.32%   61.33%   +0.01%     
==========================================
  Files        1618     1619       +1     
  Lines       18997    19002       +5     
  Branches     2683     2685       +2     
==========================================
+ Hits        11649    11654       +5     
  Misses       6868     6868              
  Partials      480      480              
Flag Coverage Δ
addon-charts 72.03% <ø> (ø)
addon-doc 50.22% <ø> (ø)
addon-editor 49.53% <ø> (ø)
addon-mobile 61.88% <ø> (ø)
addon-table 61.06% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 40.91% <ø> (ø)
core 76.98% <ø> (ø)
kit 72.71% <100.00%> (+0.02%) ⬆️
summary 61.33% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../kit/components/input-phone-international/index.ts 100.00% <100.00%> (ø)
...ternational/input-phone-international.component.ts 89.04% <100.00%> (+0.15%) ⬆️
...s/input-phone-international/utils/not-kz-region.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode merged commit 0080ac8 into main Apr 14, 2023
@splincode splincode deleted the splincode/fix/issues/4193 branch April 14, 2023 07:45
@well-done-bot
Copy link

well-done-bot bot commented Apr 14, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - InputPhoneInternational changes RU flag on KZ in case with +7 code
2 participants