-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kit): correct detect iso code for Kazakhstan & correct limit in the field for entering a phone number #5177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlufy
requested review from
waterplea,
MarsiBarsi and
vladimirpotekhin
as code owners
August 23, 2023 16:01
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
mdlufy
force-pushed
the
bugfix/TSP-1015
branch
3 times, most recently
from
August 24, 2023 11:34
e5feb5d
to
f3ab2e3
Compare
nsbarsukov
reviewed
Aug 24, 2023
projects/kit/components/input-phone-international/input-phone-international.component.ts
Outdated
Show resolved
Hide resolved
mdlufy
force-pushed
the
bugfix/TSP-1015
branch
from
August 24, 2023 14:11
f3ab2e3
to
9c68bbf
Compare
Codecov Report
@@ Coverage Diff @@
## v2.x #5177 +/- ##
=======================================
Coverage ? 57.72%
=======================================
Files ? 1068
Lines ? 11521
Branches ? 2254
=======================================
Hits ? 6650
Misses ? 4384
Partials ? 487
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nsbarsukov
reviewed
Aug 24, 2023
mdlufy
changed the title
Bugfix/tsp 1015
fix(kit): correct detect iso code for Kazakhstan & correct limit in the field for entering a phone number
Aug 24, 2023
mdlufy
force-pushed
the
bugfix/TSP-1015
branch
from
August 28, 2023 11:23
7afad1a
to
6c1d86c
Compare
nsbarsukov
approved these changes
Aug 28, 2023
splincode
approved these changes
Aug 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #4217
What is the new behavior?