Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): correct detect iso code for Kazakhstan & correct limit in the field for entering a phone number #5177

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Aug 23, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

  1. the limit of 12 characters in the field for entering a phone number
  2. when inserting a number with the code +7, the country code changes to Kazakh

Closes #4217

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 23, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@mdlufy mdlufy force-pushed the bugfix/TSP-1015 branch 3 times, most recently from e5feb5d to f3ab2e3 Compare August 24, 2023 11:34
@mdlufy mdlufy requested a review from nsbarsukov as a code owner August 24, 2023 11:34
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v2.x@1106d49). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v2.x    #5177   +/-   ##
=======================================
  Coverage        ?   57.72%           
=======================================
  Files           ?     1068           
  Lines           ?    11521           
  Branches        ?     2254           
=======================================
  Hits            ?     6650           
  Misses          ?     4384           
  Partials        ?      487           
Flag Coverage Δ
addon-charts 75.29% <0.00%> (?)
addon-doc 27.70% <0.00%> (?)
addon-editor 27.05% <0.00%> (?)
addon-mobile ∅ <0.00%> (?)
addon-table 79.59% <0.00%> (?)
addon-tablebars ∅ <0.00%> (?)
cdk 67.60% <0.00%> (?)
core 68.02% <0.00%> (?)
kit 61.22% <0.00%> (?)
summary 57.72% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mdlufy mdlufy changed the title Bugfix/tsp 1015 fix(kit): correct detect iso code for Kazakhstan & correct limit in the field for entering a phone number Aug 24, 2023
@mdlufy mdlufy requested a review from nsbarsukov August 28, 2023 11:18
@splincode splincode merged commit 73ebf15 into taiga-family:v2.x Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants