Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): support updateOn of blur and submit types for multi-select component #3398

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3386

What is the new behavior?

Screen.Recording.2023-01-11.at.02.18.20.mov

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jan 10, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jan 10, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
332.65KB (+62B +0.02%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
205.04KB +10%
demo/browser/runtime.(hash).js
34.71KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +56B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.21MB (-58B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023

Visit the preview URL for this PR (updated for commit 12321b5):

https://taiga-ui--pr3398-splincode-fix-issues-fty61o2s.web.app

(expires Fri, 13 Jan 2023 13:24:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 68.35% // Head: 68.30% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (12321b5) compared to base (e30040a).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3398      +/-   ##
==========================================
- Coverage   68.35%   68.30%   -0.05%     
==========================================
  Files        1134     1134              
  Lines       13675    13682       +7     
  Branches     1917     1920       +3     
==========================================
- Hits         9347     9346       -1     
- Misses       4001     4006       +5     
- Partials      327      330       +3     
Flag Coverage Δ
addon-charts 72.46% <ø> (ø)
addon-doc 50.00% <ø> (ø)
addon-editor 50.34% <ø> (ø)
addon-mobile 62.31% <ø> (ø)
addon-table 60.79% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk ∅ <ø> (∅)
core 76.84% <ø> (ø)
kit 72.90% <33.33%> (-0.12%) ⬇️
summary 68.30% <33.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lti-select-option/multi-select-option.component.ts 33.33% <0.00%> (-6.67%) ⬇️
...omponents/select-option/select-option.component.ts 92.00% <33.33%> (-3.84%) ⬇️
.../components/multi-select/multi-select.component.ts 77.02% <50.00%> (-0.31%) ⬇️
...ts/kit/components/combo-box/combo-box.component.ts 61.76% <100.00%> (ø)
.../kit/components/line-clamp/line-clamp.component.ts 19.04% <0.00%> (-2.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode force-pushed the splincode/fix/issues/3386 branch from 0f905c4 to 43acdd3 Compare January 11, 2023 08:40
@splincode splincode force-pushed the splincode/fix/issues/3386 branch 2 times, most recently from 4c0b9d8 to 5ba5679 Compare January 12, 2023 13:17
@splincode splincode force-pushed the splincode/fix/issues/3386 branch from 5ba5679 to 12321b5 Compare January 12, 2023 13:19
@splincode
Copy link
Member Author

@vladimirpotekhin Hello, please review me)

@splincode splincode merged commit 0a2daff into main Jan 12, 2023
@splincode splincode deleted the splincode/fix/issues/3386 branch January 12, 2023 15:18
@well-done-bot
Copy link

well-done-bot bot commented Jan 12, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Checkboxes not updated in submit mode
3 participants