Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 - Checkboxes not updated in submit mode #3386

Closed
2 of 9 tasks
Oleg979 opened this issue Jan 9, 2023 · 1 comment · Fixed by #3398
Closed
2 of 9 tasks

🐞 - Checkboxes not updated in submit mode #3386

Oleg979 opened this issue Jan 9, 2023 · 1 comment · Fixed by #3398
Assignees
@splincode
Labels
P1 This issue has high priority

Comments

@Oleg979
Copy link

Oleg979 commented Jan 9, 2023

Which @taiga-ui/* package(s) are the source of the bug?

kit

Please provide a link to a minimal reproduction of the bug

https://stackblitz.com/edit/angular-tqgx3q?file=src/app/app.module.ts

Is this issue blocking you?

Blocking

Description

tui-multi-select attached to form control with "on submit" update mode doesn't display checkboxes correctly when selecting new items

Angular version

14.2.12

Taiga UI version

3.15.0

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@Oleg979 Oleg979 changed the title 🐞 - 🐞 - Checkboxes not updated in submit mode Jan 9, 2023
@waterplea waterplea added P1 This issue has high priority and removed state: need triage labels Jan 10, 2023
@waterplea
Copy link
Collaborator

I think we can fix it by optionally injecting TuiControl and using its value if it exists, otherwise fallback to NgControl.

@splincode splincode mentioned this issue Jan 10, 2023
Merged
11 tasks
@splincode splincode self-assigned this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@splincode splincode

Labels
P1 This issue has high priority
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(kit): support updateOn of blur and submit types for multi-select component taiga-family/taiga-ui
3 participants
@waterplea @splincode @Oleg979