plot trend #565
Merged
plot trend #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
- Coverage 86.80% 86.36% -0.45%
==========================================
Files 119 119
Lines 5739 5773 +34
==========================================
+ Hits 4982 4986 +4
- Misses 757 787 +30
Continue to review full report at Codecov.
|
iKintosh
suggested changes
Feb 24, 2022
iKintosh
suggested changes
Feb 24, 2022
etna/analysis/plotters.py
Outdated
Comment on lines
773
to
776
| labels = [transform.__repr__() for transform in trend_transform] | ||
| labels_short = [i[: i.find("(")] for i in labels] | ||
| if len(np.unique(labels_short)) == len(labels_short): | ||
| labels = labels_short |
There was a problem hiding this comment.
Let's make it a private method, that constructs labels.
It should have small docsting on how it works:
If only unique transform classes are used then show their short names (without parameters)
Otherwise show their full repr as label
etna/analysis/plotters.py
Outdated
Comment on lines
777
to
779
| else: | ||
| df_detrend = [trend_transform.fit_transform(df.copy())] | ||
| labels = [trend_transform.__repr__()[: trend_transform.__repr__().find("(")]] |
There was a problem hiding this comment.
Remove this else because it repeats the code above.
etna/analysis/plotters.py
Outdated
Comment on lines
780
to
783
| if isinstance(trend_transform, LinearTrendTransform) or isinstance(trend_transform, TheilSenTrendTransform): | ||
| for seg in segments: | ||
|
|
||
| linear_coeffs[seg] = ", k=" + str(trend_transform.segment_transforms[seg]._linear_model.coef_[0]) |
There was a problem hiding this comment.
This check should be done afterwards as a separate check.
iKintosh
suggested changes
Mar 1, 2022
etna/analysis/plotters.py
Outdated
| ] | ||
|
|
||
|
|
||
| def __get_labels_names(trend_transform, segments): |
There was a problem hiding this comment.
Suggested change
| def __get_labels_names(trend_transform, segments): | |
| def _get_labels_names(trend_transform, segments): |
etna/analysis/plotters.py
Outdated
| trend_transform = [trend_transform] | ||
|
|
||
| df_detrend = [transform.fit_transform(df.copy()) for transform in trend_transform] | ||
| labels, linear_coeffs = __get_labels_names(trend_transform, segments) |
There was a problem hiding this comment.
Suggested change
| labels, linear_coeffs = __get_labels_names(trend_transform, segments) | |
| labels, linear_coeffs = _get_labels_names(trend_transform, segments) |
Same as above https://stackoverflow.com/a/1301369/7415703
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
Closing issues
closes #515