-
Notifications
You must be signed in to change notification settings - Fork 80
Change ProphetModel
and SARIMAXModel
according to latest architecture
#549
Conversation
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
==========================================
+ Coverage 87.26% 87.33% +0.06%
==========================================
Files 118 118
Lines 5788 5700 -88
==========================================
- Hits 5051 4978 -73
+ Misses 737 722 -15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a lot cleaner!
Almost ready to merge. Just need some clarification on SARIMAXAdapter
if isinstance(segment_predict, np.ndarray): | ||
segment_predict = pd.DataFrame({"target": segment_predict}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
y_pred = y_pred.reset_index(drop=True, inplace=False) | ||
rename_dict = { | ||
column: column.replace("mean", "target") for column in y_pred.columns if column.startswith("mean") | ||
} | ||
y_pred = y_pred.rename(rename_dict, axis=1) | ||
return y_pred |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
Closing issues
closes #507