Skip to content

[BUG] *Logger fails with StackingEnsemble #458 #460

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

martins0n
Copy link
Contributor

@martins0n martins0n commented Jan 19, 2022

**IMPORTANT: Please do not create a Pull Request without creating an issue first.**

## Before submitting (must do checklist)

- [x] Did you read the [contribution guide](https://github.com/tinkoff\-ai/etna/blob/master/CONTRIBUTING.md\)?
- [x] Did you update the docs? We use Numpy format for all the methods and classes.
- [x] Did you write any new necessary tests?
- [ ] Did you update the [CHANGELOG](https://github.com/tinkoff\-ai/etna/blob/master/CHANGELOG.md\)?
<!-- For CHANGELOG separate each item in unreleased section by blank line to reduce collisions -->

## Type of Change
<!-- Mark with an `x` all the checkboxes that apply (like `[x]`) -->

- [ ] Examples / docs / tutorials / contributors update
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Improvement (non-breaking change which improves an existing feature)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Proposed Changes
<!-- Add a more detailed description of the changes if needed.
No need for typos and docs improvements -->

## Related Issue
<!-- Link Issue here. -->

## Closing issues
<!-- Link Issue you are closing here.
Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such). -->
`closes #460`

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #460 (b09a09c) into master (75fd188) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
+ Coverage   87.97%   87.99%   +0.01%     
==========================================
  Files         115      115              
  Lines        5440     5448       +8     
==========================================
+ Hits         4786     4794       +8     
  Misses        654      654              
Impacted Files Coverage Δ
etna/ensembles/stacking_ensemble.py 98.31% <100.00%> (+0.01%) ⬆️
etna/loggers/base.py 95.77% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75fd188...b09a09c. Read the comment docs.

@martins0n martins0n linked an issue Jan 19, 2022 that may be closed by this pull request
1 task
Copy link
Contributor

@julia-shenshina julia-shenshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! very important fix ⭐

@julia-shenshina julia-shenshina merged commit 6370db9 into master Jan 21, 2022
@martins0n martins0n deleted the martins0n/issue458 branch January 21, 2022 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] *Logger fails with StackingEnsemble
3 participants