Skip to content

Fix default value for TSDataset.tail #245

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Fix default value for TSDataset.tail #245

merged 2 commits into from
Nov 2, 2021

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Nov 1, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

  • fix default value for TSDataset.tail,
  • add tests on TSDataset.head and TSDataset.tail with default parameters

Related Issue

#237.

Closing issues

Closes #237.

@Mr-Geekman Mr-Geekman added the bug Something isn't working label Nov 1, 2021
@Mr-Geekman Mr-Geekman self-assigned this Nov 1, 2021
@Mr-Geekman Mr-Geekman marked this pull request as ready for review November 2, 2021 07:35
@martins0n martins0n self-requested a review November 2, 2021 07:46
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n merged commit 567c798 into master Nov 2, 2021
@martins0n martins0n deleted the issue-237 branch November 2, 2021 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TSDataset.tail isn't working with default parameter
2 participants