Create method TSDataset.flatten
#241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 86.43% 86.49% +0.06%
==========================================
Files 89 89
Lines 4232 4244 +12
==========================================
+ Hits 3658 3671 +13
+ Misses 574 573 -1
Continue to review full report at Codecov.
|
etna/datasets/tsdataset.py
Outdated
| 3 2021-06-04 segment_0 1.00 | ||
| 4 2021-06-05 segment_0 1.00 | ||
| >>> df_ts_format = TSDataset.to_dataset(df) | ||
| >>> ts = TSDataset(df_ts_format, "D") |
There was a problem hiding this comment.
actually you don't need to create ts here, you can just run
df_ts_format = TSDataset.to_dataset(df)
TSDataset.to_flatten(df_ts_format).head(5)
🤔
julia-shenshina
previously approved these changes
Nov 2, 2021
tests/test_datasets/test_dataset.py
Outdated
| @@ -384,3 +384,13 @@ def test_right_format_sorting(): | |||
| inv_df = tsd.to_pandas(flatten=True) | |||
| pd.testing.assert_series_equal(df["reg_1"], inv_df["reg_1"]) | |||
| pd.testing.assert_series_equal(df["reg_2"], inv_df["reg_2"]) | |||
| ''' | |||
There was a problem hiding this comment.
Suggested change
| ''' |
tests/test_datasets/test_dataset.py
Outdated
| @@ -52,6 +51,7 @@ def df_and_regressors() -> Tuple[pd.DataFrame, pd.DataFrame]: | |||
| return df, df_exog | |||
|
|
|||
|
|
|||
| ''' | |||
There was a problem hiding this comment.
Suggested change
| ''' |
julia-shenshina
previously approved these changes
Nov 2, 2021
julia-shenshina
approved these changes
Nov 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Create method
TSDataset.flattenRelated Issue
Closing issues
closes #226