Add target components handling in get_level_dataframe
#1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1179--etna-docs.netlify.app |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1179 +/- ##
==========================================
+ Coverage 87.51% 87.67% +0.15%
==========================================
Files 166 177 +11
Lines 10093 10409 +316
==========================================
+ Hits 8833 9126 +293
- Misses 1260 1283 +23
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Mr-Geekman
suggested changes
Mar 23, 2023
Mr-Geekman
suggested changes
Mar 27, 2023
| ts_reconciled = TSDataset( | ||
| df=df_reconciled, | ||
| freq=ts.freq, | ||
| df_exog=ts.df_exog, | ||
| known_future=ts.known_future, | ||
| hierarchical_structure=ts.hierarchical_structure, | ||
| ) | ||
| if ts.target_components_names is not None: | ||
| ts_reconciled.add_target_components(target_components_df=target_components_df) |
There was a problem hiding this comment.
Same here about target_components_df.
Mr-Geekman
previously approved these changes
Mar 29, 2023
brsnw250
approved these changes
Mar 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #1169