Teach DifferencingTransform to inverse_transform with NaNs
#1155
Conversation
|
🚀 Deployed on https://deploy-preview-1155--etna-docs.netlify.app |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## inference-v2.1 #1155 +/- ##
=================================================
Coverage ? 86.89%
=================================================
Files ? 164
Lines ? 9007
Branches ? 0
=================================================
Hits ? 7827
Misses ? 1180
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| transformed.loc[start_idx:, pd.IndexSlice[current_segment, self.in_column]] = to_transform.loc[ | ||
| start_idx: | ||
| ].diff(periods=self.period) | ||
| transformed.loc[:, pd.IndexSlice[current_segment, self.in_column]] = to_transform.diff(periods=self.period) |
There was a problem hiding this comment.
May be be should rework the current test to check the new behaviour, I mean run tests in fixtures with NaNs
There was a problem hiding this comment.
What tests do you mean?
There was a problem hiding this comment.
Current tests for DifferencingTransform (test_differencing_transform) have a fixture with NaNs at the beginning. And tests check that everything is working.
There was a problem hiding this comment.
What about nans in the middle?
There was a problem hiding this comment.
Do we want to add more tests in test_differencing_transform or tests in test_inference are enough?
Ok, I'll look at it.
Before submitting (must do checklist)
Proposed Changes
Look #1136.
Closing issues
Closes #1136.