Skip to content

Improve regressors handling in TSDataset #443

Closed
1 task done
alex-hse-repository opened this issue Jan 11, 2022 · 0 comments · Fixed by #447
Closed
1 task done

Improve regressors handling in TSDataset #443

alex-hse-repository opened this issue Jan 11, 2022 · 0 comments · Fixed by #447
Assignees
Labels
bug Something isn't working
Milestone

Comments

@alex-hse-repository
Copy link
Collaborator

alex-hse-repository commented Jan 11, 2022

🚀 Feature Request

Make make_future and train_test_split pass the list of regressors to the generated datasets.

Motivation

In #327 we added parameter known_future in the constructor of TSDataset. However methods make_future and train_test_split don't use this parameter constructing the output.

Proposal

  1. Pass self.regressors to the constructor in make_future here
  2. Pass self.regressors to the constructor in train_test_split here and here
  3. Create test for this cases

Test cases

  1. Check that future part inherit the list of regressor from dataset after applying make_future
  2. Check that train and test parts inherit the list of regressor from dataset after applying train_test_split

Alternatives

No response

Additional context

No response

Checklist

  • I discussed this issue with ETNA Team
@alex-hse-repository alex-hse-repository added the bug Something isn't working label Jan 11, 2022
@alex-hse-repository alex-hse-repository added this to the Regressors 2.0 milestone Jan 11, 2022
@alex-hse-repository alex-hse-repository moved this to Specification in etna board Jan 11, 2022
@alex-hse-repository alex-hse-repository self-assigned this Jan 12, 2022
@alex-hse-repository alex-hse-repository linked a pull request Jan 12, 2022 that will close this issue
9 tasks
@alex-hse-repository alex-hse-repository moved this from Specification to In Review in etna board Jan 18, 2022
Repository owner moved this from In Review to Done in etna board Jan 24, 2022
@martins0n martins0n modified the milestones: Regressors 2.0, etna 1.6.0 Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants