Skip to content

Make regressors list always consistent with the dataset columns #444

Closed
1 task done
alex-hse-repository opened this issue Jan 11, 2022 · 0 comments
Closed
1 task done
Assignees
Labels
enhancement New feature or request

Comments

@alex-hse-repository
Copy link
Collaborator

alex-hse-repository commented Jan 11, 2022

🚀 Feature Request

The contract: "list of regressors is a subset of list of the columns" should be checked after modifying the dataset in transform loop. The extra regressors should be deleted in _update_regressors method.

Motivation

In #328 we added the regressors updating logic to TSDataset. However after applying any feature selection we get the list of regressors inconsistent with the list of columns in dataset.

Proposal

  1. Intersect the list of regressors with the list of columns in the end of _update_regressors method
  2. Remove "xfail" mark from this test and make sure that it passes

Test cases

Check that the list of regressors is consistent with the list of columns after applying FilterFeaturesTransform

Alternatives

No response

Additional context

Is blocked by #443

Checklist

  • I discussed this issue with ETNA Team
@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Jan 11, 2022
@alex-hse-repository alex-hse-repository added this to the Regressors 2.0 milestone Jan 11, 2022
@alex-hse-repository alex-hse-repository moved this to Specification in etna board Jan 11, 2022
@alex-hse-repository alex-hse-repository moved this from Specification to Todo in etna board Jan 18, 2022
@Mr-Geekman Mr-Geekman self-assigned this Feb 2, 2022
@Mr-Geekman Mr-Geekman moved this from Todo to In Progress in etna board Feb 2, 2022
@Mr-Geekman Mr-Geekman moved this from In Progress to In Review in etna board Feb 2, 2022
@iKintosh iKintosh closed this as completed Feb 3, 2022
Repository owner moved this from In Review to Done in etna board Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants