Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handling of namespace watching: #1011

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

jacobweinstock
Copy link
Member

Description

CLI flag to watch one or all namespaces.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 30.75%. Comparing base (8c7a9c8) to head (348742d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/tink-controller/main.go 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1011      +/-   ##
==========================================
- Coverage   30.86%   30.75%   -0.11%     
==========================================
  Files          75       75              
  Lines        3923     3937      +14     
==========================================
  Hits         1211     1211              
- Misses       2617     2631      +14     
  Partials       95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CLI flag to watch one or all namespaces.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock merged commit 1df09e2 into tinkerbell:main Oct 15, 2024
10 of 12 checks passed
@jacobweinstock jacobweinstock deleted the iso-mounting branch October 15, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant