Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial governance structure #44

Merged

Conversation

jacobweinstock
Copy link
Member

@jacobweinstock jacobweinstock commented Jul 21, 2021

Description

This proposes a formal start to defining the governance structure for the Tinkerbell community.

Rendered docs:

Why is this needed

tinkerbell/tink#504

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

View rendered proposals/0024/GOVERNANCE.md
View rendered proposals/0024/README.md

Signed-off-by: Jacob Weinstock <[email protected]>
| Role | Responsibilities | Requirements | Defined by |
| ----- | ---------------- | ------------ | ------- |
| Contributor | Submit contributions | signed DCO | n/a |
| Member | issue and discussion administration, PR approval | history of activity, good judgement, and contribution in the community and the repositories, Sponsored by 2 Committers | Tinkerbell GitHub org member |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to call out a specific set of requirements that someone should meet before they ask for sponsorship for each step?

For example, as outlined by https://github.com/kubernetes/community/blob/master/community-membership.md - X PR's to become a committer.

Alternatively, would you rather let that discussion happen in a follow-up PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Member | issue and discussion administration, PR approval | history of activity, good judgement, and contribution in the community and the repositories, Sponsored by 2 Committers | Tinkerbell GitHub org member |
| Member | Issue and discussion administration, PR approval | history of activity, good judgement, and contribution in the community and the repositories, sponsored by 2 Committers | Tinkerbell GitHub org member |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tstromberg, If possible I would like a follow-up PR.

I really do like the way the Kubernetes community has this laid out. I think we should definitely follow and make it explicit what requirements someone should meet before they ask for sponsorship for each step.

proposals/0024/GOVERNANCE.md Outdated Show resolved Hide resolved
proposals/0024/GOVERNANCE.md Outdated Show resolved Hide resolved
| Role | Responsibilities | Requirements | Defined by |
| ----- | ---------------- | ------------ | ------- |
| Contributor | Submit contributions | signed DCO | n/a |
| Member | issue and discussion administration, PR approval | history of activity, good judgement, and contribution in the community and the repositories, Sponsored by 2 Committers | Tinkerbell GitHub org member |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Member | issue and discussion administration, PR approval | history of activity, good judgement, and contribution in the community and the repositories, Sponsored by 2 Committers | Tinkerbell GitHub org member |
| Member | Issue and discussion administration, PR approval | history of activity, good judgement, and contribution in the community and the repositories, sponsored by 2 Committers | Tinkerbell GitHub org member |

Comment on lines 26 to 27
| Committer | Right to make changes to the code bases | same as Member and shows leadership in the community and the repositories, sponsored by 2 Maintainers | [OWNERS] file reviewer entry |
| Maintainer | Voting privileges | same as Committer, voted in by existing Maintainers | [OWNERS] file reviewer entry |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the difference between committer and maintainer only that maintainers get to vote on committers? I'm not sure we need to have a separation between committer and maintainer if we're seeking to come to consensus vs votes except for maintainer status votes. I'd rather just see the role of committer renamed to maintainer (to avoid the optics of a committer able to push commits w/o review/feedback for e.g.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consensus seeking will fall back to a vote if necessary so the voting is more than just for voting in new maintainers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, thanks for the update

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock
Copy link
Member Author

Thank you all for the approvals. I don't have permission to merge this PR. Would someone with those rights be able to merge this??

@jacobweinstock jacobweinstock merged commit e9740f0 into tinkerbell:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants