Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jq to the nix-shell environment #75

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Conversation

nshalman
Copy link
Member

@nshalman nshalman commented Apr 6, 2021

Signed-off-by: Nahum Shalman [email protected]

Description

Add jq to the nix-shell environment

Why is this needed

There are bits of documentation that use the sandbox and reference using jq from the command line.
This makes them work nicely.

How Has This Been Tested?

On NixOS running nix-shell now has jq in the PATH.

How are existing users impacted? What migration steps/scripts do we need?

N/A

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@nshalman nshalman added the ready-to-merge Signal to Mergify to merge the PR. label Apr 6, 2021
@nshalman nshalman removed the request for review from gianarb April 6, 2021 18:13
@mergify mergify bot merged commit 5347fe6 into tinkerbell:master Apr 6, 2021
@nshalman nshalman deleted the jq branch April 6, 2021 18:14
ttwd80 pushed a commit to ttwd80/tinkerbell-playground that referenced this pull request Sep 7, 2024
Signed-off-by: Nahum Shalman <[email protected]>

## Description

Add `jq` to the nix-shell environment

## Why is this needed

There are bits of documentation that use the sandbox and reference using `jq` from the command line.
This makes them work nicely.

## How Has This Been Tested?
On NixOS running `nix-shell` now has `jq` in the PATH.

## How are existing users impacted? What migration steps/scripts do we need?

N/A

## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants