Bump tink stack to newest version #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianarb
added
ci-check/vagrant-setup
thebsdbox
approved these changes
Mar 19, 2021
In preparation of v0.5.0 let's bump a few dependencies up Signed-off-by: Gianluca Arbezzano <[email protected]>
gianarb
added
ci-check/vagrant-setup
|
This PR fails the e2e tests because OSIE is currently "broken" or at least not by its own but this commit https://github.com/tinkerbell/osie/blame/97bb03b41069ea740ea5f0794ba78ccedb8ffcae/apps/workflow-helper.sh#L15 changed how tink-worker gets downloaded. Previously it was fixed to Sandbox proxies The fact that this relationship is broken with the latest osie prevents sandbox to correctly use osie and tink-worker. If @tinkerbell/site-eng can't fix it or for some reason, OSIE has to stay as it is we have 2 alternatives:
Most likely we can go with the second next week when I will work on the hook cleanup and release process. |
gauravgahlot
approved these changes
Mar 22, 2021
gianarb
pushed a commit
that referenced
this pull request
Mar 24, 2021
As I explained here #66 (comment) the current OSIE on master broke how tink-worker gets installed in sandbox. For a series of bad habits the PR got merged even if e2e tests are broken leaving sandbox/master to a not working state This commit reverts OSIE back to a fully operational version
gianarb
pushed a commit
that referenced
this pull request
Mar 24, 2021
As I explained here #66 (comment) the current OSIE on master broke how tink-worker gets installed in sandbox. For a series of bad habits the PR got merged even if e2e tests are broken leaving sandbox/master to a not working state This commit reverts OSIE back to a fully operational version Signed-off-by: Gianluca Arbezzano <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Mar 24, 2021
…#69) As I explained here #66 (comment) the current OSIE on master broke how tink-worker gets installed in sandbox. For a series of bad habits, the PR got merged even if e2e tests are broken leaving sandbox/master to a not working state This commit reverts OSIE back to a fully operational version
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
In preparation for v0.5.0 let's bump a few dependencies up to the newest versions
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
As I explained here tinkerbell#66 (comment) the current OSIE on master broke how tink-worker gets installed in sandbox. For a series of bad habits the PR got merged even if e2e tests are broken leaving sandbox/master to a not working state This commit reverts OSIE back to a fully operational version Signed-off-by: Gianluca Arbezzano <[email protected]>
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
…tinkerbell#69) As I explained here tinkerbell#66 (comment) the current OSIE on master broke how tink-worker gets installed in sandbox. For a series of bad habits, the PR got merged even if e2e tests are broken leaving sandbox/master to a not working state This commit reverts OSIE back to a fully operational version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for v0.5.0 let's bump a few dependencies up to the newest
versions