Removes conflicting composefile network instruction per #53 for boots… #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for boots container definition Signed-off-by: Joseph D. Marhee <[email protected]>
jmarhee
force-pushed
the
compose-network-boots
branch
from
95c232b
to
cf57ac7
Compare
|
Thanks a lot!! |
gianarb
approved these changes
Feb 18, 2021
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
…for boots… (tinkerbell#56) … container definition ## Description Resolves tinkerbell#53 ## Why is this needed This conflict causes container creation to fail. Fixes: # ## How Has This Been Tested? I ran the setup and was able to run a workflow and deployment without issue. ## How are existing users impacted? What migration steps/scripts do we need? No impact. ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… container definition
Description
Resolves #53
Why is this needed
This conflict causes container creation to fail.
Fixes: #
How Has This Been Tested?
I ran the setup and was able to run a workflow and deployment without issue.
How are existing users impacted? What migration steps/scripts do we need?
No impact.
Checklist:
I have: