Fix NAT and make it working for Terraform and Vagrant #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravgahlot
suggested changes
Jan 22, 2021
setup.sh
Outdated
| ) | ||
|
|
||
| do_setup() ( | ||
| o_setup() ( |
There was a problem hiding this comment.
This does not look intentional.
|
Yep I think looks good, noting the same thing that @gauravgahlot mentioned :D. |
mmlb
approved these changes
Jan 22, 2021
Commit b504810 introduced a NAT to make worker capable of reaching the public internet via the provisioner. But it also introduced a bug, it only works for the Vagrant setup as Manny pointed out: #33 (comment) This is an attempt to fix it Signed-off-by: Gianluca Arbezzano <[email protected]>
gauravgahlot
approved these changes
Jan 23, 2021
Closed
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
Commit b504810 introduced a NAT to make worker capable of reaching the public internet via the provisioner. But it also introduced a bug, it only works for the Vagrant setup as Manny pointed out: tinkerbell#33 (comment) This is an attempt to fix it @mmlb I would like to avoid additional conditions as part of the setup.sh, we have already too many of them and they are not even easy to dsicover. We have different entrypoint for those environment let's use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b504810 introduced a NAT to make worker capable of reaching the
public internet via the provisioner.
But it also introduced a bug, it only works for the Vagrant setup as
Manny pointed out:
#33 (comment)
This is an attempt to fix it
@mmlb I would like to avoid additional conditions as part of the
setup.sh, we have already too many of them and they are not even easy to
dsicover. We have different entrypoint for those environment let's use them.