Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making statement on breaking changes clearer #32

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

jgavinray
Copy link
Contributor

Description

Documentation

Why is this needed

This statement is confusing, I needed to log into the community slack to get clarification.

Fixes: #

How Has This Been Tested?

This is a documentation change and thus will not impact any software in this project.

How are existing users impacted? What migration steps/scripts do we need?

They are not, newer users may find this a little easier to digest.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Copy link
Contributor

@gianarb gianarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@gianarb gianarb removed the request for review from gauravgahlot January 4, 2021 23:06
@gianarb gianarb self-assigned this Jan 4, 2021
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Jan 4, 2021
@mergify mergify bot merged commit 0cb5e79 into tinkerbell:master Jan 4, 2021
ttwd80 pushed a commit to ttwd80/tinkerbell-playground that referenced this pull request Sep 7, 2024
## Description

Documentation

## Why is this needed

This statement is confusing, I needed to log into the community slack to get clarification.

Fixes: #

## How Has This Been Tested?
This is a documentation change and thus will not impact any software in this project.

## How are existing users impacted? What migration steps/scripts do we need?
They are not, newer users may find this a little easier to digest.


## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants