Unpack all image and not just the last layer #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go program we use to get binaries from a docker image was unpacking only the last layer. This is not required and it order to have a more generic approach and fewest requirement the program now unpack all the image Signed-off-by: Gianluca Arbezzano <[email protected]>
mmlb
reviewed
Nov 24, 2020
| if err != nil { | ||
| return err | ||
| } | ||
| err = tar.Untar(src, layerTar) |
There was a problem hiding this comment.
Is this really good enough? This won't correctly handle whiteout files in the layers. 🤔 but I guess thats fine since presumably CMD won't point to a deleted file.
mmlb
approved these changes
Nov 24, 2020
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
The go program we use to get binaries from a docker image was unpacking only the last layer. This is not required and in order to have a more generic approach and fewest requirement the program now unpack all the image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go program we use to get binaries from a docker image was unpacking
only the last layer. This is not required and in order to have a more
generic approach and fewest requirement the program now unpack all the
image