-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsupported deployment options #179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Latest Helm chart has nginx fixes for virtual hardware and tftp and Hook file serving. Remove gateway configuration because vagrant will always provision 2 interfaces. One for vagrant management that will provide the default gateway. Add kexec action to template. Signed-off-by: Jacob Weinstock <[email protected]>
New version of vagrant/virtualbox needed updating. Signed-off-by: Jacob Weinstock <[email protected]>
shell.nix is used for dependencies in the formatting, syntax checking. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
New quickstart guides are now in line with the updated process. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Air gapped and proxied environments are not supported. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
chrisdoherty4
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Jacob. Thanks!
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at ce44cf3 |
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
Remove unsupported deployment options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to simplify and provide improved support we're removing all quickstart guides except for Vagrant + Virtualbox, Vagrant + Libvirt, and Kubernetes. Under the hood all guides will only be deploying the Helm chart. Once this lands we will also rename the repository. Exact name is TBD. Possibilities include: Playground, demo, example, etc.
Why is this needed
Fixes: #169
Fixes: #167
Fixes: #177
Fixes: #8
Fixes: #175
How Has This Been Tested?
Manually tested both Libvirt and Virtualbox vagrant quick starts and the Kubernetes guide.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: