Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add persistent registry storage #122

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

detiber
Copy link
Contributor

@detiber detiber commented Feb 1, 2022

Description

Re-adds persistent registry storage to docker compose configuration

Why is this needed

Previous releases of the sandbox (<= v0.5) had persistent storage for the registry, this fixes the regression where registry storage was no longer persistent with v0.6 release and HEAD

How Has This Been Tested?

  • Bring up a clean environment, verify provisioning works
  • Push an additional image to the registry that wasn't configured in /registry/registry_images.txt
  • Do a docker compose down on the provisioner
  • Do a docker compose up on the provisioner
  • Verify that all images still exist in the registry

How are existing users impacted? What migration steps/scripts do we need?

This should not impact existing users, since it fixes the regression and issues users would encounter where registry storage is wiped when the registry container is re-created.

@detiber
Copy link
Contributor Author

detiber commented Feb 1, 2022

Currently testing this now using the vagrant/libvirt setup test plan is:

  • Bring up a clean environment, verify provisioning works
  • Push an additional image to the registry that wasn't configured in /registry/registry_images.txt
  • Do a docker compose down on the provisioner
  • Do a docker compose up on the provisioner
  • Verify that all images still exist in the registry

@detiber
Copy link
Contributor Author

detiber commented Feb 1, 2022

Ok, finished verifying locally, I believe this should be ready to go.

Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jacobweinstock jacobweinstock merged commit a2245d4 into tinkerbell:main Feb 1, 2022
ttwd80 pushed a commit to ttwd80/tinkerbell-playground that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants