Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version of skopeo #116

Merged
merged 2 commits into from
Nov 20, 2021
Merged

Pin version of skopeo #116

merged 2 commits into from
Nov 20, 2021

Conversation

swills
Copy link
Contributor

@swills swills commented Nov 20, 2021

Ran into issues with latest and the others are pinned

Description

Pin the version of skopeo

Why is this needed

I ran into issues with the latest skopeo. Pinning it avoided it, and the others seem to be pinned (at least registry and bash), so let's pin this too.

Fixes: #

How Has This Been Tested?

Yep, tested in a VM

How are existing users impacted? What migration steps/scripts do we need?

Should avoid a potential issue

Checklist:

I have:

  • [N/A] updated the documentation and/or roadmap (if required)
  • [N/A] added unit or e2e tests
  • [N/A] provided instructions on how to upgrade

Ran into issues with latest and the others are pinned

Signed-off-by: Steve Wills <[email protected]>
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Nov 20, 2021
@mmlb
Copy link
Contributor

mmlb commented Nov 20, 2021

@swills what kind of issues did you have?

@mergify mergify bot merged commit a7110f2 into tinkerbell:main Nov 20, 2021
@swills
Copy link
Contributor Author

swills commented Nov 21, 2021

@swills what kind of issues did you have?

I believe it was with certs, but I'm not sure. I can't seem to reproduce it now, so maybe it was something else and I was mistaken. v1.5.1 seems to work OK for me now.

ttwd80 pushed a commit to ttwd80/tinkerbell-playground that referenced this pull request Sep 7, 2024
Ran into issues with latest and the others are pinned

## Description

Pin the version of skopeo

## Why is this needed

I ran into issues with the latest skopeo. Pinning it avoided it, and the others seem to be pinned (at least registry and bash), so let's pin this too.

Fixes: #

## How Has This Been Tested?

Yep, tested in a VM

## How are existing users impacted? What migration steps/scripts do we need?

Should avoid a potential issue

## Checklist:

I have:

- [N/A] updated the documentation and/or roadmap (if required)
- [N/A] added unit or e2e tests
- [N/A] provided instructions on how to upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants