-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow persistentStorage - opens up multinode #63
base: main
Are you sure you want to change the base?
Conversation
c7f1880
to
3d97446
Compare
fixes tinkerbell#42 for me Signed-off-by: Randall Mason <[email protected]>
3d97446
to
5a9b9b7
Compare
@@ -18,6 +18,8 @@ stack: | |||
port: 8080 | |||
image: alpine | |||
downloadsDest: /opt/hook | |||
persistentStorage: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind if we make this opt-in and default to false here?
- ReadWriteMany | ||
resources: | ||
requests: | ||
storage: 50Gi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be customizable and can probably be a much smaller default given HookOS isn't more than a <1Gi.
@@ -18,6 +18,8 @@ stack: | |||
port: 8080 | |||
image: alpine | |||
downloadsDest: /opt/hook | |||
persistentStorage: true | |||
storageClass: ceph-filesystem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want this to be specified by the user and not default. We can add a check to one of the templates that verifies if persistentStorage == true
then require storageClass
.
Description
An example of what I did to fix #42, it works great for me!
It's also needed to be added to image downloading (https://github.com/tinkerbell/sandbox/blob/4195ea1c46f7ea9e70f297be190a81ed00ba2ec9/deploy/stack/helm/manifests/ubuntu-download.yaml) like I did here: https://github.com/ClashTheBunny/tink-settings/blob/main/tink-system/templates/download.yaml
Why is this needed
Multiple nodes
Fixes: #
How Has This Been Tested?
Works for me!
How are existing users impacted? What migration steps/scripts do we need?
The default should be not to have any change, but I'm including the overridden value to show where it would need to change.
Checklist:
I have: