Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make awk command more resilient: #57

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

jacobweinstock
Copy link
Member

Description

This fixes any issues where the nameserver line is not the second line in the resolv.conf file.

Why is this needed

Fixes: #56

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This fixes any issues where the nameserver
line is not the second line in the resolv.conf.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock added the ready-to-merge Mergify: Ready for Merging label Jul 31, 2023
@mergify mergify bot merged commit ccf0c63 into tinkerbell:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Mergify: Ready for Merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detection bug
2 participants