add nodeselector in stack deployment and make nodeselector global con… #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepauli
force-pushed
the
tink-stack-nodeselector
branch
from
d344657
to
e86028d
Compare
…figurable Signed-off-by: sepauli <[email protected]>
Signed-off-by: sepauli <[email protected]>
jacobweinstock
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added the nodeSelector in the deployment of the nginx in the stack so that the configuration from the stack/values.yaml works.
I have also modified the configuration for all deployments so that you can set the nodeSelector for all resources at the same time via "global.nodeSelector".
This makes it more easy to control on which nodes all tinkerbell resources should be deployed
How Has This Been Tested?
I have deployed tinkerbell with different nodeSelector settings and looked on which nodes the individual tinkerbell resources are scheduled
Checklist:
I have: