Update Smee version #111
Merged
Update Smee version #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI flags have changed in Smee to allow for customizing the port outside of the IP for many flags. This enables the ability for hostNetwork true mode to still allow customizing the port and using Smee's auto detection of the IP. Signed-off-by: Jacob Weinstock <[email protected]>
New version has the updated CLI flags with ports separate from IPs. Signed-off-by: Jacob Weinstock <[email protected]>
rpardini
approved these changes
Jul 11, 2024
jacobweinstock
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This version of Smee separates out ports from IPs in CLI flags. This allows us to properly do Smee
hostNetwork: true. This is a breaking change in Smee as the flags aren't the same anymore.Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: