Remove list permission on secrets for Rufio: #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unneeded and a potential security issue. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
update-perms
branch
from
cc25047
to
99265ff
Compare
jacobweinstock
added a commit
that referenced
this pull request
Jun 11, 2024
Revert "Remove list permission on secrets for Rufio:" Reverts #102 Rufio uses controller-runtime. Controller-runtime needs list permissions for its caching mechanism. _"// Cache is the cache.Options that will be used to create the default Cache. // By default, the cache will watch and list requested objects in all namespaces."_ - https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/manager#Options kubernetes-sigs/controller-runtime#1220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is unneeded and a potential security issue.
Why is this needed
Fixes: #96
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: