Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

support for azure key vault #158

Closed
codethatrocks opened this issue Nov 14, 2018 · 13 comments
Closed

support for azure key vault #158

codethatrocks opened this issue Nov 14, 2018 · 13 comments

Comments

@codethatrocks
Copy link

Hi, are there plans for supporting Azure in addition to GCP and AWS KMS?

@thaidn
Copy link
Contributor

thaidn commented Nov 16, 2018

It's not high priority at the moment, but if you can contribute we'll help review your code.

@thaidn
Copy link
Contributor

thaidn commented Mar 25, 2019

Yes it is.

@thaidn
Copy link
Contributor

thaidn commented Mar 26, 2019 via email

@przydatek
Copy link
Contributor

Hi @99M8 , are you still interested in contributing?

@przydatek
Copy link
Contributor

Closing for now, as we don't have resources to work on it, but potential contributors are encouraged to re-open.

@pawelprazak
Copy link

asking theoretically, what size would this task be, M, L?

@thaidn
Copy link
Contributor

thaidn commented Dec 4, 2020

It's similar to #405.

@thaidn thaidn reopened this Dec 4, 2020
@thejasn
Copy link

thejasn commented Aug 25, 2021

Hey @thaidn,
Is anyone working on this? I would like to contribute here (for go, maybe java as well).

@sfc-gh-kleonhard
Copy link
Contributor

sfc-gh-kleonhard commented Jan 13, 2023

This looks pretty easy, but - Azure key vault doesn't support symmetric keys so the implementation would need to use an asymmetric RSA key (RSA-OAEP-256). The interface in aead.go accepts AAD, but it isn't passed when encrypting DEKs with the remote KMS (code.

Anyone willing to weigh in?

@tholenst
Copy link
Contributor

tholenst commented Feb 9, 2023

Over the years we found several reason to redesign our KMS integration. I will leave this open for now though -- but we should first do the redesign.

@sfc-gh-kleonhard
Copy link
Contributor

Thanks Thomas. If the reasons are written down somewhere, I'd be curious to see them for my own understanding.

My two cents - without Azure support, there's a whole swatch of multi-cloud users that won't adopt Tink.

@tholenst tholenst added the p3 label Mar 20, 2023
@svrakitin
Copy link

svrakitin commented Nov 7, 2023

Hi, did the redesign happen? If not, are you still open to accept Azure Key Vault integration with the current design?

@tholenst
Copy link
Contributor

We don't plan this and I will close this. The issue is that maintaining these integrations is not trivial. Furthermore, an implementation can be done by anyone (not just us) in a separate repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants