Use the minimum billable vCPU and GB for Container Instances (#710)

tinglesoftware · Jul 17, 2023 · 25e6014 · 25e6014
1 parent 4b4025d
commit 25e6014
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 29 deletions.
diff --git a/server/Tingle.Dependabot.Tests/Models/UpdateJobResourcesTests.cs b/server/Tingle.Dependabot.Tests/Models/UpdateJobResourcesTests.cs
@@ -11,28 +11,4 @@ public void FromEcosystem_Works()
         var values = Enum.GetValues<DependabotPackageEcosystem>();
         Assert.All(values, ecosystem => UpdateJobResources.FromEcosystem(ecosystem));
     }
-
-    [Theory]
-    [InlineData(DependabotPackageEcosystem.Bundler, 0.25, 0.5)]
-    [InlineData(DependabotPackageEcosystem.Cargo, 0.25, 0.5)]
-    [InlineData(DependabotPackageEcosystem.Composer, 0.25, 0.5)]
-    [InlineData(DependabotPackageEcosystem.Docker, 0.25, 0.5)]
-    [InlineData(DependabotPackageEcosystem.Elixir, 0.25, 0.5)]
-    [InlineData(DependabotPackageEcosystem.Elm, 0.25, 0.5)]
-    [InlineData(DependabotPackageEcosystem.GitSubmodule, 0.1, 0.2)]
-    [InlineData(DependabotPackageEcosystem.GithubActions, 0.25, 0.5)]
-    [InlineData(DependabotPackageEcosystem.GoModules, 0.25, 0.5)]
-    [InlineData(DependabotPackageEcosystem.Gradle, 0.25, 0.5)]
-    [InlineData(DependabotPackageEcosystem.Maven, 0.25, 0.5)]
-    [InlineData(DependabotPackageEcosystem.Mix, 0.25, 0.5)]
-    [InlineData(DependabotPackageEcosystem.Npm, 0.25, 1.0)]
-    [InlineData(DependabotPackageEcosystem.NuGet, 0.25, 0.2)]
-    [InlineData(DependabotPackageEcosystem.Pip, 0.25, 0.5)]
-    [InlineData(DependabotPackageEcosystem.Terraform, 0.25, 1.0)]
-    public void FromEcosystem_ExpectedValues(DependabotPackageEcosystem ecosystem, double expectedCpu, double expectedMemory)
-    {
-        var resources = UpdateJobResources.FromEcosystem(ecosystem);
-        Assert.Equal(expectedCpu, resources.Cpu);
-        Assert.Equal(expectedMemory, resources.Memory);
-    }
 }
diff --git a/server/Tingle.Dependabot/Models/UpdateJobResources.cs b/server/Tingle.Dependabot/Models/UpdateJobResources.cs
@@ -31,13 +31,14 @@ public UpdateJobResources(double cpu, double memory)
 
     public static UpdateJobResources FromEcosystem(DependabotPackageEcosystem ecosystem)
     {
+        // the minimum we can be billed for on Container Instances is 1vCPU and 1GB, we might as well use it
         return ecosystem switch
         {
-            DependabotPackageEcosystem.NuGet => new(cpu: 0.25, memory: 0.2),
-            DependabotPackageEcosystem.GitSubmodule => new(cpu: 0.1, memory: 0.2),
-            DependabotPackageEcosystem.Terraform => new(cpu: 0.25, memory: 1),
-            DependabotPackageEcosystem.Npm => new(cpu: 0.25, memory: 1),
-            _ => new UpdateJobResources(cpu: 0.25, memory: 0.5),
+            //DependabotPackageEcosystem.NuGet => new(cpu: 0.25, memory: 0.2),
+            //DependabotPackageEcosystem.GitSubmodule => new(cpu: 0.1, memory: 0.2),
+            //DependabotPackageEcosystem.Terraform => new(cpu: 0.25, memory: 1),
+            //DependabotPackageEcosystem.Npm => new(cpu: 0.25, memory: 1),
+            _ => new UpdateJobResources(cpu: 1, memory: 1), // the minimum
         };
     }