BuildConfig: Fix validation for module platform compatibility #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tindzk
force-pushed
the
bug/build-validation-custom-targets
branch
2 times, most recently
from
76d8f71
to
977c3bf
Compare
The validation triggered a false positive for modules with custom build targets. The compatibility must be checked for all platform-specific modules separately since these may depend on additional modules which are not included on the base module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation triggered a false positive for modules with custom
build targets.
The compatibility must be checked for all platform-specific modules
separately since these may depend on additional modules which are
not included on the base module.