Refactor build path logic #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if tmpfs is disabled, `BuildTarget` uses an output path that is different from the generated Bloop project. Introduce `PathUtil` to unify the build path logic across the entire code base and write test cases. Also, change the path of the linked Bloop artefacts from `build/bloop/` to `build/`. When packaging modules, place `dist/` under the same build path. Further changes: - Idea: Move `normalisePath()` to `PathUtil` - `Cli`: Improve help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if tmpfs is disabled,
BuildTargetuses an output paththat is different from the generated Bloop project. Introduce
PathUtilto unify the build path logic across the entire code baseand write test cases.
Also, change the path of the linked Bloop artefacts from
build/bloop/tobuild/. When packaging modules, placedist/under the same build path.
Further changes:
normalisePath()toPathUtilCli: Improve help