-
Notifications
You must be signed in to change notification settings - Fork 91
Fixed eslint & console errors #58
base: master
Are you sure you want to change the base?
Conversation
Updated npm libraries to fix all warnings in JS Console.
|
Bruce Ingalls seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an approved contributor here, so take this with a grain of salt.
There's a lot of good stuff here, but it feels like it should be at least 3 separate pull requests, rather than one big one. Some of this is great, but other stuff is not desirable or unrelated.
package.json
Outdated
"gatsby-plugin-tinacms": "^0.24.0", | ||
"gatsby-plugin-transition-link": "^1.20.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like upgrading packages is unrelated to fixing linting errors. Why bundle them into the same pull request?
@@ -0,0 +1,15 @@ | |||
import React from "react" | |||
|
|||
class NotFoundPage extends React.Component { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you added this, but again, this feels like it should be a separate PR.
Fixed all errors & warnings in Eslint & JS Console.
2 warnings remain:
componentWillMount
remains