Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Fixed eslint & console errors #58

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Conversation

bingalls
Copy link

@bingalls bingalls commented Aug 2, 2020

Fixed all errors & warnings in Eslint & JS Console.
2 warnings remain:

  • deprecated componentWillMount remains
  • socket.io does not set MIME type

@bingalls bingalls closed this Aug 16, 2020
@bingalls bingalls reopened this Aug 16, 2020
@bingalls
Copy link
Author

Updated npm libraries to fix all warnings in JS Console.

  • yarn outdated is clean
  • yarn audit is clean
    Still needs work for eslint & prettier

@bingalls bingalls closed this Aug 17, 2020
@bingalls bingalls reopened this Aug 17, 2020
@DirtyF DirtyF marked this pull request as draft August 17, 2020 09:52
@CLAassistant
Copy link

CLAassistant commented Sep 24, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bingalls
❌ Bruce Ingalls


Bruce Ingalls seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bingalls bingalls marked this pull request as ready for review September 25, 2020 22:50
Copy link
Contributor

@PaulMorel1 PaulMorel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an approved contributor here, so take this with a grain of salt.

There's a lot of good stuff here, but it feels like it should be at least 3 separate pull requests, rather than one big one. Some of this is great, but other stuff is not desirable or unrelated.

content/pages/home.json Outdated Show resolved Hide resolved
package.json Outdated
Comment on lines 24 to 25
"gatsby-plugin-tinacms": "^0.24.0",
"gatsby-plugin-transition-link": "^1.20.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like upgrading packages is unrelated to fixing linting errors. Why bundle them into the same pull request?

@@ -0,0 +1,15 @@
import React from "react"

class NotFoundPage extends React.Component {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you added this, but again, this feels like it should be a separate PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants