Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interactive animations to cube in hero section #30

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

timsexperiments
Copy link
Owner

@timsexperiments timsexperiments commented Jun 12, 2024

This PR introduces several key enhancements to the Hero component in the timsexperiments app:

  1. Skeleton Loading Animation:

    • Added a new Skeleton component to the ui directory for loading placeholders.
    • Integrated Skeleton animations in the Hero component for better visual feedback during loading.
  2. PointerControl:

    • Introduced a new PointerControl component to provide a visual pointer interaction.
    • Incorporated PointerControl into the Hero component to enhance user guidance.
  3. RubiksCubeControl:

    • Improved the existing RubiksCubeControl with enhanced animations and transitions.
  4. Code Refactoring:

    • Refactored cube.ts script for better readability and maintainability.
    • Organized imports and cleaned up unused code.
  5. Tailwind Configuration:

    • Added new animation keyframes and transition classes to support new animations.

How to test?

  1. Load the Hero component in the timsexperiments application.
  2. Observe the Skeleton loading animations during data fetch/load.
  3. Interact with the Hero component and verify the new PointerControl and RubiksCubeControl functionalities.
  4. Ensure no console errors and animations/transitions work smoothly.

Why make this change?

  • To improve user experience through better visual feedback and interactive elements in the Hero component.
  • Enhancements in the code for long-term maintainability and readability.

Copy link

cloudflare-workers-and-pages bot commented Jun 12, 2024

Deploying timsexperiments-foo with  Cloudflare Pages  Cloudflare Pages

Latest commit: c2cd0ac
Status: ✅  Deploy successful!
Preview URL: https://4d9a2357.timsexperiments-foo.pages.dev
Branch Preview URL: https://06-11-add-cube-tutorial.timsexperiments-foo.pages.dev

View logs

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timsexperiments and the rest of your teammates on Graphite Graphite

Copy link

Your database schema is up-to-date.

@timsexperiments timsexperiments marked this pull request as ready for review June 12, 2024 03:31
@timsexperiments timsexperiments changed the title Add cube tutorial Add interactive animations to cube in hero section Jun 12, 2024
Copy link

Your database schema is up-to-date.

@timsexperiments timsexperiments merged commit 616f492 into main Jun 12, 2024
2 checks passed
@timsexperiments timsexperiments deleted the 06-11-add_cube_tutorial branch July 16, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant