Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work orders do not print the PDF #306

Closed
efeoli opened this issue Dec 12, 2024 · 9 comments
Closed

Work orders do not print the PDF #306

efeoli opened this issue Dec 12, 2024 · 9 comments

Comments

@efeoli
Copy link
Collaborator

efeoli commented Dec 12, 2024

          > I agree the work order doesn't print yet, but I can find nothing wrong elsewhere. Can you elaborate any further.

Tim

The issue had been discussed within this entry. I am sorry that the many requests generally speaking, make mine a nagging affair.
Just let me know what I can do to keep things simple.
Enrique

Originally posted by @efeoli in #217 (comment)

@efeoli
Copy link
Collaborator Author

efeoli commented Dec 16, 2024

This issue is related to
#224 (comment)

@efeoli
Copy link
Collaborator Author

efeoli commented Dec 19, 2024

The App seems to be near production status. However, various printing problems are extensive (generic as Ricard suggests #316 (comment)) despite the improved printing from migration to better PDF libraries, like printing how a supplier’s payment is allocated.
Captura de pantalla_18-12-2024_18337_kwa bioacyl com

Doesn’t this merit getting fixed to start testing the App in production environments.

This also applies to sending emails with a PDF involved.
Enrique

@aingelc12ell
Copy link
Contributor

Hi @efeoli

Kindly update on this if still an issue after the fixes made. We'll help out in cleaning and fixing of the issues.

Regards,

@efeoli
Copy link
Collaborator Author

efeoli commented Dec 28, 2024 via email

@efeoli
Copy link
Collaborator Author

efeoli commented Dec 28, 2024

Hi again,
I was lucky to connect and test the latest. However, still a tcpdf error:

Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /home/bioacylc/domains/bioacyl.com/kwa.bioacyl.com/webERP/includes/tcpdf/tcpdf.php:15679 Stack trace: #0 /home/bioacylc/domains/bioacyl.com/kwa.bioacyl.com/webERP/PDFWOPrint.php(490): TCPDF->write2DBarcode() #1 {main} thrown in /home/bioacylc/domains/bioacyl.com/kwa.bioacyl.com/webERP/includes/tcpdf/tcpdf.php on line 15679

Enrique

@aingelc12ell
Copy link
Contributor

Thanks for the heads up @efeoli

I pushed the fix on this one complying with the parameter requirements of TCPDF's write2DBarcode()

@efeoli
Copy link
Collaborator Author

efeoli commented Jan 3, 2025

Thanks for the heads up @efeoli

I pushed the fix on this one complying with the parameter requirements of TCPDF's write2DBarcode()
Hi,
Is the commit separate from Tim Schofield’s? I continue to get the TCPDF error by downloading the last commit.
Enrique

pakricard added a commit that referenced this issue Jan 4, 2025
Fix #306: TCPDF expects associative array, empty string is passed. All credit to @aingelc12ell
@pakricard
Copy link
Collaborator

Thanks, @aingelc12ell.
It is my first pull request approval, so if something regarding this PR is still off, please let me know

@dalers
Copy link
Collaborator

dalers commented Jan 8, 2025

Could the BOM printing issue (#325) be related in any way to this PR?

Printing a BOM shows only an "X" in the preview screen instead of the parts list using 2025-01-07 commit f4f32a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants