-
Notifications
You must be signed in to change notification settings - Fork 123
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install prnMsg not displayed #25
Comments
I have done the change on the error message, and pushed the commit. I will need to think how to do the other change you suggest. Tim |
@andrewcouling thinking about this there are a number of places in the installer where prnMsg() is called, and as header.php and footer.php are never used then the messages won't get displayed using the new system. Is it worth having a prnMsgInstaller() function? |
All |
Merge pull request #30 from TurboPT/master
Merge pull request #25 from timschofield/master
Fixes applied, many thanks. tim |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
The
install/index.php
file makes an initial check for theconfig.php
file and is expected to exit after displaying a message. Thefunction prnMsg()
merely appends the message to an array to be displayed at the end of the script, but the very next statement isexit;
which makes sure that the script gets truncated thereat.Hence, replace line 156 of
install/index.php
:with
Furthermore, if the database exists and no tables exist in it, then, the script should be allowed to skip over db creation and
config.php
creation and proceed to database table creation.The text was updated successfully, but these errors were encountered: