Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install prnMsg not displayed #25

Closed
apmuthu opened this issue Mar 31, 2018 · 4 comments
Closed

Install prnMsg not displayed #25

apmuthu opened this issue Mar 31, 2018 · 4 comments

Comments

@apmuthu
Copy link
Contributor

apmuthu commented Mar 31, 2018

The install/index.php file makes an initial check for the config.php file and is expected to exit after displaying a message. The function prnMsg() merely appends the message to an array to be displayed at the end of the script, but the very next statement is exit; which makes sure that the script gets truncated thereat.

Hence, replace line 156 of install/index.php:

		prnMsg(_('It seems that the system has been already installed. If you want to install again, please remove the config.php file first'),'error');

with

		echo _('It seems that the system has been already installed. If you want to install again, please remove the config.php file first');

Furthermore, if the database exists and no tables exist in it, then, the script should be allowed to skip over db creation and config.php creation and proceed to database table creation.

@timschofield
Copy link
Owner

I have done the change on the error message, and pushed the commit.

I will need to think how to do the other change you suggest.

Tim

@timschofield
Copy link
Owner

@andrewcouling thinking about this there are a number of places in the installer where prnMsg() is called, and as header.php and footer.php are never used then the messages won't get displayed using the new system. Is it worth having a prnMsgInstaller() function?

@apmuthu
Copy link
Contributor Author

apmuthu commented Apr 1, 2018

All prnMsg have been replaced with echo statements in the install/index.php file.
Diff and changed files attached.
PrnMsg_echo_diff.zip

timschofield pushed a commit that referenced this issue Apr 2, 2018
Merge pull request #30 from TurboPT/master
timschofield added a commit that referenced this issue Apr 2, 2018
Merge pull request #25 from timschofield/master
@timschofield
Copy link
Owner

Fixes applied, many thanks.

tim

Repository owner locked and limited conversation to collaborators Sep 29, 2024
@timschofield timschofield converted this issue into discussion #172 Sep 29, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants