[superseded] fix #16265; fix #13999 (HCR on OSX); cgen now does not line wrap string litterals #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
changed the title
…h, in combination with other hacks, caused a really obscure looking bug
timotheecour
force-pushed
the
pr_cgen_nowrap_strings
branch
from
5714fab to
b74e0fc
Compare
This was referenced Dec 11, 2020
timotheecour
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix nim-lang#16265
fix nim-lang#13999
When you combine 2 ugly hacks you get those kind of bugs...
This was really painful to debug.
=> nim-lang#16329