fix nim-lang#11590: c compiler warnings silently ignored, giving unde…

…fined behavior
timotheecour · Nov 26, 2019 · 3ec2a9a · 3ec2a9a
1 parent bc75f7f
commit 3ec2a9a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/compiler/extccomp.nim b/compiler/extccomp.nim
@@ -844,8 +844,7 @@ proc execCmdsInParallel(conf: ConfigRef; cmds: seq[string]; prettyCb: proc (idx:
     let exitCode = p.peekExitCode
     if exitCode != 0:
       rawMessage(conf, errGenerated, "execution of an external compiler program '" &
-        cmds[idx] & "' failed with exit code: " & $exitCode & "\n\n" &
-        p.outputStream.readAll.strip)
+        cmds[idx] & "' failed with exit code: " & $exitCode & "\n\n")
   if conf.numberOfProcessors == 0: conf.numberOfProcessors = countProcessors()
   var res = 0
   if conf.numberOfProcessors <= 1:
@@ -857,14 +856,16 @@ proc execCmdsInParallel(conf: ConfigRef; cmds: seq[string]; prettyCb: proc (idx:
           cmds[i])
   else:
     tryExceptOSErrorMessage(conf, "invocation of external compiler program failed."):
+      # keep writing errors/warnings to stderr
+      let defaultOpt = {poParentStreams, poUsePath}
       if optListCmd in conf.globalOptions or conf.verbosity > 1:
-        res = execProcesses(cmds, {poEchoCmd, poStdErrToStdOut, poUsePath},
+        res = execProcesses(cmds, {poEchoCmd} + defaultOpt,
                             conf.numberOfProcessors, afterRunEvent=runCb)
       elif conf.verbosity == 1:
-        res = execProcesses(cmds, {poStdErrToStdOut, poUsePath},
+        res = execProcesses(cmds, defaultOpt,
                             conf.numberOfProcessors, prettyCb, afterRunEvent=runCb)
       else:
-        res = execProcesses(cmds, {poStdErrToStdOut, poUsePath},
+        res = execProcesses(cmds, defaultOpt,
                             conf.numberOfProcessors, afterRunEvent=runCb)
   if res != 0:
     if conf.numberOfProcessors <= 1:

diff --git a/config/nim.cfg b/config/nim.cfg
@@ -228,7 +228,9 @@ llvm_gcc.options.size = "-Os"
 # Configuration for the LLVM CLang compiler:
 clang.options.debug = "-g"
 clang.cpp.options.debug = "-g"
-clang.options.always = "-w"
+# pending fixing `sem.nim.c:16829:37: error: & has lower precedence than ==`
+# when compiling nim, we can remove `-Wno-error=parentheses`
+clang.options.always = "-Werror -Wno-error=parentheses"
 clang.options.speed = "-O3"
 clang.options.size = "-Os"