Make sure to_rdf output is Send
#79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JsonLdProcessor::to_rdffunction is triggering rust-lang/rust#100013, making it unusable in a multi-threaded environment since the compiler is unable to check that the output (aFuture) ofto_rdfisSend. The only fix I know is to remove all the lifetime related to this function.Instead of passing the vocabulary and generator by reference, they are now passed by move. As far as I know this is not an issue since
VocabularyMutis also implemented for&mut VandGeneratorfor&mut Ganyway, so it's still possible to pass them by reference.This is yet another breaking change though...