Added support for consecutive asterisks at the beginning or end

[martinssipenko]

According to CODEOWNERS Syntax doc, CODEOWNERS file uses a pattern that follows most of the same rules used in gitignore files.

This Pull Requests adds support for consecutive asterisks at the beginning or end (**/foo, foo/**). The case where asterisks are in the middle (a/**/b) was already supported.

[timoschinkel]

Hi Martins,

Thank you for your pull request. I will try to have a closer look later this week. On first glance it looks good, although I'm wondering about the replacement of /** with .*, maybe that should be \/.*.

I see that something has changed in the configuration of Psalm causing the inspections to fail. I will look at that as well.

[martinssipenko]

I fixed Psalm in #21 and rebased this PR.

I just tried using \/.* instead of .* locally and the tests were failing. Honestly, I have not invested time to fully understand the inner working of the library, so I don't know what would be the best solution. I encountered an issue with **/foo case, so I added a test and patched code to make it work, duplicating the ** case (.*) seemed the simplest option.

[timoschinkel]

No problem. I will try to look at your pull request before the end of the week. This pull request requires a bit more attention compared to #21.

[martinssipenko]

Sure, in the mean time I'll use my forked version. Thanks!

[timoschinkel]

Can you add the suggested test cases to \CodeOwners\Tests\PatternMatcherTest::provideNoMatchFoundExceptionIsThrownForFilename()? I think your current solution is too forgiving and will result in incorrect results.

[timoschinkel]

Suggested change

	'/**' => '.*',
	'/**' => '\/.*',

I think we do need to add the slashes. I have created a pull request on a test repository to verify some edge cases. I have added a coworker as codeowner to that repository: https://github.com/timoschinkel/test-repository/pull/6/files

For the rule docs/** that does apply to docs/file.md and docs/folder/file.md, but not to docs.md.

These situations can be tested by adding the following lines to \CodeOwners\Tests\PatternMatcherTest::provideNoMatchFoundExceptionIsThrownForFilename():

            // **
            [new Pattern('**/foo', ['@owner']), 'foo.ext'],
            [new Pattern('foo/**', ['@owner']), 'foo.ext'],

[martinssipenko]

@timoschinkel Updated code as per your suggestions.

[timoschinkel]

Sorry, but I did find an issue with the **/ pattern. I've supplied a test case and I have verified this with a pull request on GitHub: https://github.com/timoschinkel/test-repository/pull/6/files

If we apply this fix then this change can be merged I think.

[martinssipenko]

@timoschinkel done

[timoschinkel]

Thank you for the contribution. I just released this in 2.1.0.