Apply suggestions from code review

Co-authored-by: Timo Schinkel <[email protected]>
timoschinkel · Jun 29, 2022 · 588eaba · 588eaba
1 parent 1042e3e
commit 588eaba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/PatternMatcher.php b/src/PatternMatcher.php
@@ -63,7 +63,7 @@ private function isMatch(Pattern $pattern, string $filename): bool
                 '?' => '[^\/]',
                 '**' => '.*',
                 '/**' => '\/.*',
-                '**/' => '.*',
+                '**/' => '.*\/',
                 '/**/' => '\/([^\/]+\/)*',
             ];
 

diff --git a/tests/PatternMatcherTest.php b/tests/PatternMatcherTest.php
@@ -134,6 +134,7 @@ public function provideNoMatchFoundExceptionIsThrownForFilename(): array
 
             // **
             [new Pattern('**/foo', ['@owner']), 'foo.ext'],
+            [new Pattern('**/foo', ['@owner']), 'bar-foo/file.ext'],
             [new Pattern('foo/**', ['@owner']), 'foo.ext'],
         ];
     }
-Original file line number
+Diff line change
@@ Expand Up @@
                 // **
                 [new Pattern('**/foo', ['@owner']), 'foo.ext'],
+                [new Pattern('**/foo', ['@owner']), 'bar-foo/file.ext'],
                 [new Pattern('foo/**', ['@owner']), 'foo.ext'],
             ];
         }
@@ Expand Down @@