Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Gitlab #6

Closed
timoschinkel opened this issue Jan 8, 2020 · 2 comments · Fixed by #8
Closed

Add support for Gitlab #6

timoschinkel opened this issue Jan 8, 2020 · 2 comments · Fixed by #8
Labels
enhancement New feature or request

Comments

@timoschinkel
Copy link
Owner

timoschinkel commented Jan 8, 2020 •
edited
Loading

Support in the SearchFileLocator is now available for Github and Bitbucket, but Gitlab should probably be supported as well.

Additionally both Gitlab and Github also support docs/CODEOWNERS. BitBucket does not appear to support docs/CODEOWNERS as a viable location.

I'm unable to find the priority in which Github, Gitlab and BitBucket search. Others seem to suggest root > .github > docs > .gitlab. Might be worth an investigation.
@timoschinkel timoschinkel added the enhancement New feature or request label Jan 8, 2020
@timoschinkel
Copy link
Owner Author

timoschinkel commented Jan 22, 2020 •
edited
Loading

This repository seems to suggest the order of loading on Github at least is: root > docs/ > .github/: https://github.com/code-owners/codeowners-api/blob/master/src/githubApi/codeownerLocator.ts

On the other hand this repository suggest the order is exactly the other way around: https://github.com/jamiebuilds/codeowners-utils/blob/master/src/codeowners-utils.ts

@timoschinkel
Copy link
Owner Author

A direct answer from Github Support:

Thank you for reaching out to GitHub Support.

CODEOWNERS files can be in any of these locations:

  • .github/
  • the root of the repository
  • docs/

If there are multiple CODEOWNERS files in a repository, we will use the first one we find in the above order.

timoschinkel added a commit that referenced this issue Jan 23, 2020
@timoschinkel
Add support for Gitlab
bba9a75 
- Add support for Gitlab when searching for a CODEOWNERS file
- Change the order in which is searched for a CODEOWNERS file after an answer from Github to `.github/|.bitbucket/|.gitlab/` > `root` > `docs/`

Fixes #6
@timoschinkel timoschinkel mentioned this issue Jan 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Gitlab timoschinkel/codeowners-cli
1 participant
@timoschinkel