Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes commenting on interpolated elixir tags #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fklement
Copy link

@fklement fklement commented Feb 1, 2019

As using <%# some content %> as block comment doesn't really work well in .html.eex templates i changed them to the normal html block comment tags.

Comments before (wrong):
<%# <%= form_for @conn, initiate_path(@conn, :create), [errors: @conn.assigns[:errors]], fn f -> %> %>
Comments now (right):
<!-- <%= form_for @conn, initiate_path(@conn, :create), [errors: @conn.assigns[:errors]], fn f -> %> -->

Commenting in .html.eex templates now works as it should for me.

@fklement fklement changed the title Fix problem #144 Fixes #144 Feb 1, 2019
@fklement fklement changed the title Fixes #144 Fixes: #144 commenting on interpolated elixir tags Feb 1, 2019
@fklement fklement changed the title Fixes: #144 commenting on interpolated elixir tags Fixes commenting on interpolated elixir tags Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant